Skip to content

Add varrock guilds#873

Merged
GregHib merged 10 commits intomainfrom
add-varrock-guilds
Feb 3, 2026
Merged

Add varrock guilds#873
GregHib merged 10 commits intomainfrom
add-varrock-guilds

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Feb 3, 2026

  • Add cooks guild and npc dialogues
  • Add champions guild and npc dialogues
  • Fixed woodcutting anims not clearing
  • Fixed buying trimmed 99 capes
  • Fixed tabs & closing shops hiding them
  • Fixed scripts sometimes not loading
  • Fixed returning restless ghost skull
  • Fixed restless ghost achievement task not being removed from tasks list.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Qodana Community for JVM

7 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 10.19108% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.07%. Comparing base (d0ed815) to head (440d975).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rea/misthalin/varrock/cooks_guild/RomilyWeaklax.kt 3.12% 62 Missing ⚠️
...ent/area/misthalin/varrock/cooks_guild/HeadChef.kt 6.89% 27 Missing ⚠️
...t/area/misthalin/varrock/cooks_guild/CooksGuild.kt 13.33% 13 Missing ⚠️
...t/area/misthalin/varrock/champions_guild/Scavvo.kt 16.66% 10 Missing ⚠️
...isthalin/varrock/champions_guild/ChampionsGuild.kt 18.18% 9 Missing ⚠️
.../area/misthalin/varrock/champions_guild/Valaine.kt 25.00% 6 Missing ⚠️
...a/misthalin/varrock/champions_guild/Guildmaster.kt 28.57% 5 Missing ⚠️
.../content/area/asgarnia/rimmington/CraftingGuild.kt 0.00% 2 Missing ⚠️
.../kotlin/content/area/asgarnia/taverley/Kaqemeex.kt 0.00% 2 Missing ⚠️
game/src/main/kotlin/content/entity/Movement.kt 0.00% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
Files with missing lines Coverage Δ
...src/main/kotlin/content/entity/player/modal/Tab.kt 100.00% <100.00%> (ø)
...area/misthalin/lumbridge/church/LumbridgeChurch.kt 9.25% <0.00%> (ø)
...rc/main/kotlin/content/entity/npc/shop/ShopOpen.kt 73.68% <0.00%> (-1.32%) ⬇️
...in/kotlin/content/entity/player/modal/GameFrame.kt 82.69% <0.00%> (ø)
.../content/area/asgarnia/rimmington/CraftingGuild.kt 6.25% <0.00%> (-0.14%) ⬇️
.../kotlin/content/area/asgarnia/taverley/Kaqemeex.kt 1.69% <0.00%> (-0.02%) ⬇️
game/src/main/kotlin/content/entity/Movement.kt 72.22% <0.00%> (-2.78%) ⬇️
...a/misthalin/varrock/champions_guild/Guildmaster.kt 28.57% <28.57%> (ø)
.../area/misthalin/varrock/champions_guild/Valaine.kt 25.00% <25.00%> (ø)
...isthalin/varrock/champions_guild/ChampionsGuild.kt 18.18% <18.18%> (ø)
... and 4 more 
@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
- Coverage     37.14%   37.07%   -0.07%     
- Complexity     7263     7270       +7     
============================================
  Files          1506     1513       +7     
  Lines         59230    59382     +152     
  Branches      14933    14994      +61     
============================================
+ Hits          22002    22017      +15     
- Misses        32263    32399     +136     
- Partials       4965     4966       +1
Components Coverage Δ
Content 34.27% <10.19%> (-0.11%) ⬇️
Engine 42.81% <ø> (ø)
Network 60.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 4f54fbf into main Feb 3, 2026
5 checks passed
@GregHib GregHib deleted the add-varrock-guilds branch February 3, 2026 15:56
@GregHib GregHib mentioned this pull request Feb 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GregHib